Ensure FIND_PACKAGE PythonInterp called before PythonLibs #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmcclain
force-pushed
the
cmakeordering
branch
from
35677c1 to
8216bca
Compare
markmcclain
changed the title
markmcclain
force-pushed
the
cmakeordering
branch
from
ec65be7 to
8dfc05e
Compare
Upstream Cmake docs specify that PythonInterp should be called before PythonLibs[1]. In some environments, inconsistency is possible when called out of order. [1] https://cmake.org/cmake/help/latest/module/FindPythonInterp.html
markmcclain
force-pushed
the
cmakeordering
branch
from
8dfc05e to
b344251
Compare
|
Don't you also need to adjust the first lines of the cmake file, so that you get python2 if both python2 and python3 are to be built? |
|
Python2 + Python3 works correctly. The problem is reproducible if python3.y and python3.y+n interpreters are available on the system. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Cmake docs specify that PythonInterp should be called before
PythonLibs[1]. Inconsistency is possible when called with PythonLib first
in some environments.
[1] https://cmake.org/cmake/help/latest/module/FindPythonInterp.html